Skip to content

Conversation

@bowenli86
Copy link
Contributor

Motivation:

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications:

Describe the modifications you've done.

Result:

After your change, what will change.

bowenli86 added 22 commits April 1, 2025 11:33
**Motivation:**

chain_id is currently an github secrets, but not used anywhere

**Modifications:**

remove chain id from secrets and env vars 

**Result:**

one less useless secret, no impact on ci
**Motivation:**

per eigengit, main will be the new canonical branch

**Modifications:**

change push branch from dev to main

**Result:**

ci will be run on PRs against main
**Motivation:**

fork-based pr cannot use secrets or github token

**Modifications:**

disable auto labeler to prepare for enabling fork-based pr

**Result:**

auto labeler is disabled, will be potentially removed in future soon
**Motivation:**

*Explain here the context, and why you're making that change. What is
the problem you're trying to solve.*

**Modifications:**

*Describe the modifications you've done.*

**Result:**

*After your change, what will change.*
**Motivation:**

remove holesky rpc since it's not used anywhere

**Modifications:**

remove holesky rpc

**Result:**

remove holesky rpc
**Motivation:**

make testing of fork based pr easier by splitting workflows require
secrets vs not

**Modifications:**

splitting workflows require secrets vs not into 2 gh workflow files

**Result:**

splitting workflows require secrets vs not into 2 gh workflow files
@bowenli86 bowenli86 force-pushed the main branch 4 times, most recently from b6b9c4c to 5ffb1b8 Compare April 21, 2025 21:08
@bowenli86 bowenli86 closed this by deleting the head repository May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant